[Bugfix] allow pending data to send before exit#98
Merged
Conversation
kezhenxu94
reviewed
Dec 11, 2020
Comment on lines
+41
to
+43
| __protocol.report(__queue) # is blocking actually | ||
| while __protocol.report(__queue): # blocking but has timeout | ||
| pass |
Member
There was a problem hiding this comment.
So maybe this is unnecessary after your latest commit? And there is no timeout actually (the comment says it has, which is confusing)
Contributor
Author
There was a problem hiding this comment.
You are right on both counts, the return True from Protocol.report() also becomes unnecessary, stuck around from first commit. [EDIT] Meaning that the while loop should also be removed, if you don't do this now I will do it tomorrow.
kezhenxu94
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the problem of last pending data not being sent on exit.